Author Topic: Style change with button code  (Read 4719 times)

0 Members and 1 Guest are viewing this topic.

skynetsolutions

  • Jr. Member
  • **
  • Posts: 2
Style change with button code
« on: June 02, 2017, 12:11:33 AM »
So I have duplicated the default style and called it accreditationnow

I see it in the operator section as I should.

I create button code and select that I want to use that style and the code generated clearly shows &style=accreditationnow in the query string that is passed.

I scoured the web and forum looking to see if I've done something wrong and I couldn't solve the issue so I went poking around in the code.

Inside /libs/classes/Mibew/Style/ChatStyle.php

Inside function getFilesPath()

I changed return 'styles/chats/' . $this->getName();

To be return 'styles/chats/' . $this->getCurrentStyle();

Fixed my problem and I'm not finding anything broken.

It appears this is a legit bug but I'm not confident enough to just post it to GitHub.


faf

  • Mibew Staff Member
  • Native
  • *****
  • Posts: 950
    • Mibew Messenger
Re: Style change with button code
« Reply #1 on: June 04, 2017, 05:03:24 PM »
Thanks for reporting the issue.

Looks like there is a bug, but at the moment I'm not quite sure where exactly it is, and how to fix it in a right manner. I'll take a look at this in the near future and post the conclusion.

UPD.: It seems that I located and fixed the bug. But it will take some additional time for me to make sure that it's really fixed now.
« Last Edit: June 05, 2017, 03:40:47 PM by faf »

faf

  • Mibew Staff Member
  • Native
  • *****
  • Posts: 950
    • Mibew Messenger
Re: Style change with button code
« Reply #2 on: June 15, 2017, 04:39:01 PM »
So, at last I've managed to fix the issues related to styles (both for chats and invitations).  ;)

It's in the repo now. And since it's an important fix, probably soon we'll release the next version of Mibew Messenger.

skynetsolutions

  • Jr. Member
  • **
  • Posts: 2
Re: Style change with button code
« Reply #3 on: July 13, 2017, 03:36:16 PM »
Excellent. Thanks for looking into it!